Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for nz-breadcrumb with autoGenerate enabled #5523

Closed
deedarb opened this issue Jul 7, 2020 · 4 comments · Fixed by #5545
Closed

Translation for nz-breadcrumb with autoGenerate enabled #5523

deedarb opened this issue Jul 7, 2020 · 4 comments · Fixed by #5545

Comments

@deedarb
Copy link

deedarb commented Jul 7, 2020

What problem does this feature solve?

In routes there is option to add to data "breadcrumb" property, which will be used in breadcrumb autogeneration. If app have multiple translation languages then there is no option to translate "breadcrumb".

What does the proposed API look like?

<nz-breadcrumb [nzAutoGenerate]="true">
  <nz-breadcrumb-template>{{breadcrumb | customTranslatePipe}}</nz-breadcrumb-template>
</nz-breadcrumb>

or pass function

<nz-breadcrumb [nzAutoGenerate]="true" [labelFn]="customTranslationFn"></nz-breadcrumb>
@wzhudev wzhudev added Good First Issue Issues recommended for first-time contributor help wanted 🌈 Feature Request labels Jul 10, 2020
@zorro-bot
Copy link

zorro-bot bot commented Jul 10, 2020

Hello @deedarb. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @deedarb, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

@wzhudev
Copy link
Member

wzhudev commented Jul 10, 2020

That's a good idea! @deedarb Welcome to submit a PR. We will review it ASAP.

@deedarb
Copy link
Author

deedarb commented Jul 10, 2020

Hi, thanks for response, i'll try to implement it, which API is OK?
Passing function or template or both? Names of attributes/tags is OK?
Maybe change labelFn to nzLabelFn?

@deedarb
Copy link
Author

deedarb commented Nov 19, 2020

sorry for commenting in closed issue, implemented function should handle promises and have type:

(label: string) => string | Promise<string>

this is required if you use ngx-translate or transloco services, they provide async and sync methods to translate, but if you use sync translate and provider didn't finished downloading translation it will not provide translation

should i open new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants