New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ng:6.0): support angular 6.0 #1404

Merged
merged 7 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@vthinkxie
Member

vthinkxie commented May 8, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: close #1395

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@vthinkxie

This comment has been minimized.

Show comment
Hide comment
@vthinkxie

vthinkxie May 8, 2018

Member

blocked by angular/devkit#866 now.

Member

vthinkxie commented May 8, 2018

blocked by angular/devkit#866 now.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot May 11, 2018

Codecov Report

Merging #1404 into master will decrease coverage by 1.04%.
The diff coverage is 99.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
- Coverage   97.03%   95.99%   -1.05%     
==========================================
  Files         224      466     +242     
  Lines        9766    10948    +1182     
  Branches     1340     1448     +108     
==========================================
+ Hits         9476    10509    +1033     
- Misses         42      124      +82     
- Partials      248      315      +67
Impacted Files Coverage Δ
...mponents/input-number/nz-input-number.component.ts 98.99% <ø> (ø) ⬆️
...ents/time-picker/nz-time-picker-panel.component.ts 86.32% <ø> (ø) ⬆️
components/steps/nz-steps.component.ts 96.72% <ø> (ø) ⬆️
...uto-complete/nz-autocomplete-optgroup.component.ts 100% <ø> (ø) ⬆️
components/slider/nz-slider-track.component.ts 100% <ø> (ø) ⬆️
components/anchor/nz-anchor-link.component.ts 100% <ø> (ø) ⬆️
components/breadcrumb/nz-breadcrumb.component.ts 100% <ø> (ø) ⬆️
components/date-picker/date-picker.component.ts 87.5% <ø> (ø) ⬆️
components/rate/nz-rate.component.ts 98.63% <ø> (ø) ⬆️
components/modal/nz-modal-ref.class.ts 100% <ø> (ø) ⬆️
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fbf135...89c3f59. Read the comment docs.

codecov bot commented May 11, 2018

Codecov Report

Merging #1404 into master will decrease coverage by 1.04%.
The diff coverage is 99.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
- Coverage   97.03%   95.99%   -1.05%     
==========================================
  Files         224      466     +242     
  Lines        9766    10948    +1182     
  Branches     1340     1448     +108     
==========================================
+ Hits         9476    10509    +1033     
- Misses         42      124      +82     
- Partials      248      315      +67
Impacted Files Coverage Δ
...mponents/input-number/nz-input-number.component.ts 98.99% <ø> (ø) ⬆️
...ents/time-picker/nz-time-picker-panel.component.ts 86.32% <ø> (ø) ⬆️
components/steps/nz-steps.component.ts 96.72% <ø> (ø) ⬆️
...uto-complete/nz-autocomplete-optgroup.component.ts 100% <ø> (ø) ⬆️
components/slider/nz-slider-track.component.ts 100% <ø> (ø) ⬆️
components/anchor/nz-anchor-link.component.ts 100% <ø> (ø) ⬆️
components/breadcrumb/nz-breadcrumb.component.ts 100% <ø> (ø) ⬆️
components/date-picker/date-picker.component.ts 87.5% <ø> (ø) ⬆️
components/rate/nz-rate.component.ts 98.63% <ø> (ø) ⬆️
components/modal/nz-modal-ref.class.ts 100% <ø> (ø) ⬆️
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fbf135...89c3f59. Read the comment docs.

@arnaudschlupp

This comment has been minimized.

Show comment
Hide comment
@arnaudschlupp

arnaudschlupp May 14, 2018

Hi! I was wondering, do you have any idea when this could land to master? A lot of folks will be happy about this :) and thanks a lot for the work you are doing here!

arnaudschlupp commented May 14, 2018

Hi! I was wondering, do you have any idea when this could land to master? A lot of folks will be happy about this :) and thanks a lot for the work you are doing here!

@vthinkxie

This comment has been minimized.

Show comment
Hide comment
@vthinkxie

vthinkxie May 14, 2018

Member

Hi @arnaudschlupp will be merge into master in this month, thanks.

Member

vthinkxie commented May 14, 2018

Hi @arnaudschlupp will be merge into master in this month, thanks.

@HsuanXyz HsuanXyz referenced this pull request May 15, 2018

Closed

build: compile less #1445

1 of 3 tasks complete

@vthinkxie vthinkxie merged commit ebd5555 into NG-ZORRO:master May 31, 2018

4 checks passed

codecov/patch 99.59% of diff hit (target 97.03%)
Details
codecov/project Absolute coverage decreased by -1.04% but relative coverage increased by +2.56% compared to 0fbf135
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@vthinkxie vthinkxie deleted the vthinkxie:angular-6.0 branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment