Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix option incorrect active status #141

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

SangKa
Copy link
Contributor

@SangKa SangKa commented Aug 24, 2017

Fix #139

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #139

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 52.271% when pulling 757ab21 on SangKa:fix-select-first-option-status into 143c080 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 49e3741 into NG-ZORRO:master Aug 25, 2017
suraciii pushed a commit to suraciii/ng-zorro-antd that referenced this pull request Aug 30, 2017
* master:
  refactor(module:dropdown): improve performance (NG-ZORRO#148)
  feat(module:tooltip,popconfirm,popover): support OnPush (NG-ZORRO#143)
  release(0.5.0-rc.3): pre-release 0.5.0-rc.3 (NG-ZORRO#166)
  fix(module:carousel): fix carousel auto play bug (NG-ZORRO#164)
  fix(module:input): fix input disabled style bug (NG-ZORRO#160)
  fix(module:input): fix input disabled style bug (NG-ZORRO#108)
  fix(module:affix,anchor,back-top): fix and improve rxjs usage (NG-ZORRO#159)
  feat(module:affix&anchor&back-top&avatar): add components to library (NG-ZORRO#88)
  fix(module:select): fix select reset bug in form (NG-ZORRO#153)
  fix(module:pagination) fix pagination double binding (NG-ZORRO#146)
  fix(module:select): fix option incorrect active status (NG-ZORRO#141)
  feat(module:root): make nz-root optional (NG-ZORRO#36)
@SangKa SangKa deleted the fix-select-first-option-status branch February 10, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Select component, first option always has active css
3 participants