refactor(module:dropdown): improve performance #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brooooooklyn
force-pushed
the
refactor/dropdown
branch
from
c8e5134
to
88dee68
Compare
trotyl
reviewed
Aug 25, 2017
| import { debounceTime } from 'rxjs/operator/debounceTime'; | ||
| import 'rxjs/add/operator/debounceTime'; | ||
| import 'rxjs/add/operator/do'; | ||
| import 'rxjs/add/operator/merge'; |
There was a problem hiding this comment.
Library should not use rxjs patching mechanism as suggested in angular/components#5314
Brooooooklyn
force-pushed
the
refactor/dropdown
branch
from
88dee68
to
35d92a2
Compare
trotyl
reviewed
Aug 25, 2017
| } from '@angular/core'; | ||
| import { Subject } from 'rxjs/Subject'; | ||
| import { debounceTime } from 'rxjs/operator/debounceTime'; | ||
| import 'rxjs/add/operator/debounceTime'; |
There was a problem hiding this comment.
Library should not use rxjs patching mechanism as suggested in angular/components#2622, angular/components#2652, angular/components#3716, angular/components#5314 (original line has been modified)
Brooooooklyn
force-pushed
the
refactor/dropdown
branch
from
35d92a2
to
bd4e82f
Compare
|
are you sure it works? |
LinboLen
reviewed
Aug 25, 2017
| this._renderer.listen(this._nzOrigin.elementRef.nativeElement, 'mouseenter', () => this._show()); | ||
| this._renderer.listen(this._nzOrigin.elementRef.nativeElement, 'mouseleave', () => this._hide()); | ||
| mouse$ = Observable.create((observer: Observer<boolean>) => { | ||
| const disposeMouseEnter = this._renderer.listen(this._nzOrigin.elementRef.nativeElement, 'mouseenter', () => { |
There was a problem hiding this comment.
should check whether will fire ngzone. although this component will not check
There was a problem hiding this comment.
Zone propagation for RxJS has been fixed on Zone.js side already.
1. use Observable to replace Subject, which could dispose eventListener. 2. use ChangeDetectionStrategy.OnPush to reduce check times.
Brooooooklyn
force-pushed
the
refactor/dropdown
branch
from
bd4e82f
to
f88c1fa
Compare
|
Concerns irrelevant to this PR, currently all event triggers are generalized and applied to a debounce of |
trotyl
approved these changes
Aug 29, 2017
suraciii
pushed a commit
to suraciii/ng-zorro-antd
that referenced
this pull request
Aug 30, 2017
* master: refactor(module:dropdown): improve performance (NG-ZORRO#148) feat(module:tooltip,popconfirm,popover): support OnPush (NG-ZORRO#143) release(0.5.0-rc.3): pre-release 0.5.0-rc.3 (NG-ZORRO#166) fix(module:carousel): fix carousel auto play bug (NG-ZORRO#164) fix(module:input): fix input disabled style bug (NG-ZORRO#160) fix(module:input): fix input disabled style bug (NG-ZORRO#108) fix(module:affix,anchor,back-top): fix and improve rxjs usage (NG-ZORRO#159) feat(module:affix&anchor&back-top&avatar): add components to library (NG-ZORRO#88) fix(module:select): fix select reset bug in form (NG-ZORRO#153) fix(module:pagination) fix pagination double binding (NG-ZORRO#146) fix(module:select): fix option incorrect active status (NG-ZORRO#141) feat(module:root): make nz-root optional (NG-ZORRO#36)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information