Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:upload): add directory support #2164

Merged
merged 20 commits into from
Sep 21, 2018
Merged

feat(module:upload): add directory support #2164

merged 20 commits into from
Sep 21, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 19, 2018

includes:

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2164 into master will decrease coverage by 0.02%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
- Coverage      96%   95.98%   -0.03%     
==========================================
  Files         479      479              
  Lines       11697    11712      +15     
  Branches     1564     1569       +5     
==========================================
+ Hits        11230    11242      +12     
- Misses        132      133       +1     
- Partials      335      337       +2
Impacted Files Coverage Δ
components/upload/nz-upload.component.ts 99.37% <100%> (-0.01%) ⬇️
components/upload/nz-upload-btn.component.ts 98.07% <90%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ff576...cf7efb4. Read the comment docs.

@vthinkxie vthinkxie merged commit 3ef8bcf into NG-ZORRO:master Sep 21, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants