Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:time-picker): place the clear button to outside of th… #2948

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

wilsoncook
Copy link
Member

…e time picker panel

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 8d2ede1

https://deploy-preview-2948--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2948 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2948      +/-   ##
==========================================
+ Coverage   97.36%   97.37%   +<.01%     
==========================================
  Files         526      526              
  Lines       11053    11052       -1     
  Branches      796      796              
==========================================
  Hits        10762    10762              
+ Misses        183      182       -1     
  Partials      108      108
Impacted Files Coverage Δ
...ents/time-picker/nz-time-picker-panel.component.ts 92.39% <ø> (-0.7%) ⬇️
components/time-picker/nz-time-picker.component.ts 96.73% <100%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd7752...902d111. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 902d111

https://deploy-preview-2948--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit ffb6665 into NG-ZORRO:master Feb 21, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants