Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tag): support fully control by user #3100

Closed
wants to merge 2 commits into from

Conversation

CoderPoet
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Checkable tags now support full user control

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #3100 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
- Coverage   97.37%   97.32%   -0.06%     
==========================================
  Files         559      550       -9     
  Lines       11627    11515     -112     
  Branches      835      821      -14     
==========================================
- Hits        11322    11207     -115     
- Misses        193      199       +6     
+ Partials      112      109       -3
Impacted Files Coverage Δ
components/tag/nz-tag.component.ts 100% <100%> (ø) ⬆️
components/cascader/nz-cascader-li.component.ts 88.88% <0%> (-5.56%) ⬇️
components/tree/nz-tree-node.ts 88.79% <0%> (-3.12%) ⬇️
components/core/polyfill/request-animation.ts 21.73% <0%> (-2.08%) ⬇️
components/breadcrumb/nz-breadcrumb.component.ts 57.14% <0%> (-1.84%) ⬇️
components/core/util/logger/logger.service.ts 70.58% <0%> (-1.64%) ⬇️
components/menu/nz-submenu.service.ts 91.42% <0%> (-0.47%) ⬇️
components/cascader/nz-cascader.component.ts 99.23% <0%> (-0.4%) ⬇️
...mponents/message/nz-message-container.component.ts 96.55% <0%> (-0.33%) ⬇️
components/tree/nz-tree-base.service.ts 96.87% <0%> (-0.31%) ⬇️
... and 295 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c0d53...2943185. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 29, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2943185

https://deploy-preview-3100--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your pr!
tslint error, plz fix it and rebase onto master

@wzhudev
Copy link
Member

wzhudev commented Aug 7, 2019

@CoderPoet ping~ Are you stilling working on this? I could take it over if you will.

@wzhudev
Copy link
Member

wzhudev commented Sep 9, 2019

Closed due to inactivity. Please reopen another PR if you still would like to contribute. Thank you.

BTW, I didn't see this feature is implemented in antd. Could you please describe the use case?

@wzhudev wzhudev closed this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants