Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:carousel): support custom strategies #3501

Merged
merged 5 commits into from
Jun 5, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 28, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Users can provide custom strategies to make transitions between carousel items.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev changed the title feat(module:cascader): support custom strategies feat(module:carousel): support custom strategies May 28, 2019
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #3501 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3501      +/-   ##
==========================================
+ Coverage    95.6%   95.61%   +<.01%     
==========================================
  Files         609      610       +1     
  Lines       13250    13258       +8     
  Branches     1810     1811       +1     
==========================================
+ Hits        12668    12676       +8     
  Misses        197      197              
  Partials      385      385
Impacted Files Coverage Δ
components/carousel/nz-carousel.component.ts 93.71% <100%> (+0.24%) ⬆️
components/carousel/nz-carousel-definitions.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6342657...855bcfe. Read the comment docs.

@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit b031750

https://deploy-preview-3501--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 855bcfe

https://deploy-preview-3501--ng-zorro-master.netlify.com

components/test.ts Outdated Show resolved Hide resolved
@wenqi73 wenqi73 merged commit a53a43a into NG-ZORRO:master Jun 5, 2019
@wzhudev wzhudev deleted the carousel-strategy branch June 20, 2019 09:47
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:cascader): support custom strategies

* docs: add docs

* test: add test

* docs: fix typo

* fix: fix test and tsconfig
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:cascader): support custom strategies

* docs: add docs

* test: add test

* docs: fix typo

* fix: fix test and tsconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants