Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump to Angular 8.0.0 #3529

Merged
merged 3 commits into from Jun 11, 2019
Merged

chore: bump to Angular 8.0.0 #3529

merged 3 commits into from Jun 11, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jun 3, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: #3514

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jun 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit afe6cd4

https://deploy-preview-3529--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 3, 2019 •
edited

Codecov Report

Merging #3529 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3529      +/-   ##
==========================================
+ Coverage   95.67%   95.69%   +0.02%     
==========================================
  Files         690      690              
  Lines       13692    13692              
  Branches     1824     1824              
==========================================
+ Hits        13100    13103       +3     
  Misses        201      201              
+ Partials      391      388       -3
Impacted Files Coverage Δ
components/core/tree/nz-tree-base.service.ts 94.66% <ø> (ø) ⬆️
components/empty/nz-empty.component.ts 100% <ø> (ø) ⬆️
components/calendar/nz-calendar.component.ts 97.76% <ø> (ø) ⬆️
components/tree/nz-tree.component.ts 98.59% <100%> (ø) ⬆️
components/drawer/nz-drawer.component.ts 96.49% <100%> (-0.03%) ⬇️
components/menu/nz-submenu.component.ts 100% <100%> (ø) ⬆️
components/popover/nz-popover.component.ts 100% <100%> (ø) ⬆️
components/comment/nz-comment-cells.ts 95.65% <100%> (+0.19%) ⬆️
components/upload/nz-upload.component.ts 99.28% <100%> (ø) ⬆️
components/select/nz-option-container.component.ts 95.34% <100%> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690692...cb69950. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 3, 2019 •
edited

Deploy preview for ng-zorro-master ready!

Built with commit cb69950

https://deploy-preview-3529--ng-zorro-master.netlify.com

wzhudev
wzhudev approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
@lppedd
Copy link
Contributor

lppedd commented Jun 10, 2019 •
edited

I would suggest waiting for 8.1 before merging. The first beta already fixed a lot of bugs.

@vthinkxie
Copy link
Member

I would suggest waiting for 8.1 before merging. The first beta already fixed a lot of bugs.

yes, we will try to release ng-zorro-antd 8.0 after angular 8.1 released

vthinkxie
vthinkxie reviewed Jun 11, 2019
View reviewed changes
components/button/nz-button.component.ts
@@ -59,7 +59,7 @@ export class NzButtonComponent implements AfterContentInit, OnInit, OnDestroy, O
readonly el: HTMLElement = this.elementRef.nativeElement;
private iconElement: HTMLElement;
private iconOnly = false;
@ViewChild('contentElement') contentElement: ElementRef;
@ViewChild('contentElement', { static: true }) contentElement: ElementRef;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is static true required here

vthinkxie
vthinkxie approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 43aeaeb into NG-ZORRO:master Jun 11, 2019
@lppedd
Copy link
Contributor

lppedd commented Jun 12, 2019

See this document for Ivy breaking changes, so that you might have a better overview of the things to change in the future : )
https://docs.google.com/document/d/1Dije0AsJ0PxL3NaeNPxpYDeapj30b_QC0xfeIvIIzgg/preview

@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
chore: bump to Angular 8.0.0 (NG-ZORRO#3529)
03b56eb 
* chore: bump to Angular 8.0.0

test: fix test

docs: update docs

* test: fix test

* fix(module:descriptions): add static flag for v8
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz @vthinkxie
chore: bump to Angular 8.0.0 (NG-ZORRO#3529)
7eec880 
* chore: bump to Angular 8.0.0

test: fix test

docs: update docs

* test: fix test

* fix(module:descriptions): add static flag for v8
@hsuanxyz hsuanxyz deleted the v8 branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hsuanxyz @lppedd @vthinkxie @wzhudev