Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): Fix link button wave #3546

Closed
wants to merge 4 commits into from
Closed

fix(module:button): Fix link button wave #3546

wants to merge 4 commits into from

Conversation

zhhb
Copy link

@zhhb zhhb commented Jun 6, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Button with nzType link behave diff from the version of react

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

the comments change is components/core/responsive/index.ts and components/core/responsive/public-api.ts was maked by npm run lint

@netlify
Copy link

netlify bot commented Jun 6, 2019

Deploy preview for ng-zorro-master ready!

Built with commit cb91c9a

https://deploy-preview-3546--ng-zorro-master.netlify.com

@zhhb zhhb changed the title Fix link button wave fix(module:button): Fix link button wave Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #3546 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
+ Coverage   95.67%   95.69%   +0.01%     
==========================================
  Files         690      690              
  Lines       13692    13696       +4     
  Branches     1824     1826       +2     
==========================================
+ Hits        13100    13106       +6     
+ Misses        201      200       -1     
+ Partials      391      390       -1
Impacted Files Coverage Δ
components/core/responsive/public-api.ts 100% <ø> (ø) ⬆️
components/button/nz-button.component.ts 93.05% <75%> (-1.07%) ⬇️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️
components/core/wave/nz-wave.directive.ts 90% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690692...cb91c9a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #3546 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
+ Coverage   95.67%   95.69%   +0.01%     
==========================================
  Files         690      690              
  Lines       13692    13696       +4     
  Branches     1824     1826       +2     
==========================================
+ Hits        13100    13106       +6     
+ Misses        201      200       -1     
+ Partials      391      390       -1
Impacted Files Coverage Δ
components/core/responsive/public-api.ts 100% <ø> (ø) ⬆️
components/button/nz-button.component.ts 93.05% <75%> (-1.07%) ⬇️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️
components/core/wave/nz-wave.directive.ts 90% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690692...cb91c9a. Read the comment docs.

@vthinkxie vthinkxie closed this in ccb68ae Jun 14, 2019
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Jun 14, 2019
…ZORRO#3545)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close NG-ZORRO#3546
vthinkxie pushed a commit that referenced this pull request Jun 14, 2019
…) (#3572)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close #3546
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ZORRO#3545)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close NG-ZORRO#3546
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ZORRO#3545)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close NG-ZORRO#3546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant