Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:*): global config #3568

Closed
wants to merge 7 commits into from
Closed

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 14, 2019

poc: use decorator to extract property

屏幕快照 2019-06-14 10 38 53

All buttons are set to 'large' by configuration.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jun 14, 2019

Deploy preview for ng-zorro-master ready!

Built with commit b790b48

https://deploy-preview-3568--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3568 into master will decrease coverage by 0.17%.
The diff coverage is 86.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   95.74%   95.57%   -0.18%     
==========================================
  Files         689      692       +3     
  Lines       13705    13847     +142     
  Branches     1821     1844      +23     
==========================================
+ Hits        13122    13234     +112     
- Misses        195      218      +23     
- Partials      388      395       +7
Impacted Files Coverage Δ
components/layout/demo/custom-trigger.ts 100% <ø> (ø) ⬆️
components/menu/demo/theme.ts 100% <ø> (ø) ⬆️
components/button/demo/icon.ts 100% <ø> (ø) ⬆️
components/notification/nz-notification.service.ts 100% <ø> (ø) ⬆️
components/menu/demo/inline-collapsed.ts 83.33% <ø> (ø) ⬆️
components/layout/demo/side.ts 100% <ø> (ø) ⬆️
components/menu/demo/sider-current.ts 100% <ø> (ø) ⬆️
components/layout/demo/responsive.ts 100% <ø> (ø) ⬆️
components/button/demo/size.ts 100% <ø> (ø) ⬆️
components/menu/demo/inline.ts 100% <ø> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbe7c2...b790b48. Read the comment docs.

Wendell added 2 commits June 19, 2019 16:46
poc: use decorator to extract property

WIP

feat(module:message,notification): support global config

docs: add docs of global config

feat(module:icon): support config service

docs: update icon docs

docs: add English translation of global config

feat(module:empty): support config service

feat(module:cascader): support global config service

feat(module:carousel): support config service

feat(module:descriptions): support config service

fix(module:*): replace icon type with new API

fix: ci related to decorator function

fix: fix decorator

fix: again

fix: decorator
@wzhudev wzhudev marked this pull request as ready for review June 20, 2019 08:53
@wzhudev
Copy link
Member Author

wzhudev commented Jun 20, 2019

I am going to reopen a pull request since this looks stuck...

@wzhudev wzhudev closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant