feat(module:carousel): support dot position #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit b873607 |
wzhudev
force-pushed
the
carousel-new-feature
branch
from
54f0439
to
1098151
Compare
Codecov Report
@@ Coverage Diff @@
## master #3575 +/- ##
==========================================
+ Coverage 95.72% 95.73% +<.01%
==========================================
Files 690 690
Lines 13708 13727 +19
Branches 1824 1827 +3
==========================================
+ Hits 13122 13141 +19
Misses 198 198
Partials 388 388
Continue to review full report at Codecov.
|
wzhudev
added
PR::eyes: Need Review
PR: unreviewed
and removed
PR::eyes: Need Review
labels
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:carousel): support dot position * fix(module:carousel): fix content height in vertical mode * fix: typo
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:carousel): support dot position * fix(module:carousel): fix content height in vertical mode * fix: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Dots can be placed on the top, left, bottom or right.
nzVerticalis deprecated and will be removed in 9.0.0.Does this PR introduce a breaking change?
Other information