Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): disable year and month selection if set nzDi… #3589

Closed
wants to merge 1 commit into from

Conversation

lzdw
Copy link

@lzdw lzdw commented Jun 17, 2019

…sabledDate property (#3425)

close #3425

  • fix(module:date-picker): setting the date after today is not optional, the year and month after today should be disabled

  • add test

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 3425

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@lzdw lzdw closed this Jun 17, 2019
@netlify
Copy link

netlify bot commented Jun 17, 2019

Deploy preview for ng-zorro-master ready!

Built with commit df77496

https://deploy-preview-3589--ng-zorro-master.netlify.com

@lzdw lzdw deleted the issue-date-picker branch June 17, 2019 03:35
@lzdw lzdw restored the issue-date-picker branch June 17, 2019 04:00
@lzdw lzdw reopened this Jun 17, 2019
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3589 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3589   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files         689      689           
  Lines       13705    13705           
  Branches     1821     1821           
=======================================
  Hits        13122    13122           
  Misses        195      195           
  Partials      388      388

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b893520...df77496. Read the comment docs.

…ssabledDate property (NG-ZORRO#3425)

close NG-ZORRO#3425

* fix(module:date-picker): setting the date after today is not optional, the year and month after today should be disabled

* add test
@wenqi73
Copy link
Member

wenqi73 commented Jun 20, 2019

@zhidanluo 感谢 PR。有个地方不太合理:先选了2018年9月,再选择年份,此时2019年不可选。必须要月份小于当前月才行。有无更好的解法?
https://deploy-preview-3589--ng-zorro-master.netlify.com/components/date-picker/zh#components-date-picker-demo-disabled-date

@lzdw
Copy link
Author

lzdw commented Jun 28, 2019

@zhidanluo 感谢 PR。有个地方不太合理:先选了2018年9月,再选择年份,此时2019年不可选。必须要月份小于当前月才行。有无更好的解法?
https://deploy-preview-3589--ng-zorro-master.netlify.com/components/date-picker/zh#components-date-picker-demo-disabled-date

ok, 确实这样。我先把 PR 关闭。有其他方案时再提交。

@lzdw lzdw closed this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

日期控件增加不可选日期后,年、月选择并没有被禁用掉
4 participants