Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix border-right of small size and bordered table #4027

Merged
merged 6 commits into from
Aug 26, 2019
Merged

fix(module:table): fix border-right of small size and bordered table #4027

merged 6 commits into from
Aug 26, 2019

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

fix https://stackblitz.com/edit/ng-zorro-antd-start-b1cu6m?file=src%2Fapp%2Fapp.component.html

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 19, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d79c0de

https://deploy-preview-4027--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #4027 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4027   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         506      506           
  Lines       10749    10749           
  Branches     1942     1942           
=======================================
  Hits         9934     9934           
  Misses        400      400           
  Partials      415      415
Impacted Files Coverage Δ
components/resizable/nz-resize-handle.component.ts 100% <0%> (ø) ⬆️
components/calendar/date-table-cell.component.ts 100% <0%> (ø) ⬆️
components/typography/nz-text-edit.component.ts 100% <0%> (ø) ⬆️
components/code-editor/nz-code-editor.component.ts 10.66% <0%> (ø) ⬆️
components/typography/nz-typography.component.ts 98.95% <0%> (ø) ⬆️
components/modal/nz-modal-footer.directive.ts 50% <0%> (ø) ⬆️
components/result/partial/unauthorized.ts 100% <0%> (ø) ⬆️
components/dropdown/nz-dropdown-a.directive.ts 100% <0%> (ø) ⬆️
components/resizable/nz-resizable.directive.ts 91.27% <0%> (ø) ⬆️
components/typography/nz-text-copy.component.ts 96.42% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272e32a...d79c0de. Read the comment docs.

components/table/style/size.less Outdated Show resolved Hide resolved
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit a3bd531 into NG-ZORRO:master Aug 26, 2019
@danranVm danranVm deleted the fix-table-style branch November 25, 2019 16:44
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…G-ZORRO#4027)

* fix(module:table): fix border-right of small size and bordered table

* fix(module:table): style path

* fix(module:table): revert demo

* fix(module:table): style patch

* fix(module:table): style patch

* fix(module:table): style patch
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…G-ZORRO#4027)

* fix(module:table): fix border-right of small size and bordered table

* fix(module:table): style path

* fix(module:table): revert demo

* fix(module:table): style patch

* fix(module:table): style patch

* fix(module:table): style patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants