Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:page-header): fix break change on the style #4303

Merged
merged 1 commit into from Oct 23, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4208 (review)

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a859427

https://deploy-preview-4303--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #4303 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4303      +/-   ##
==========================================
- Coverage   92.16%   92.15%   -0.01%     
==========================================
  Files         520      520              
  Lines       11016    11016              
  Branches     1997     1997              
==========================================
- Hits        10153    10152       -1     
  Misses        431      431              
- Partials      432      433       +1
Impacted Files Coverage Δ
components/page-header/nz-page-header.component.ts 100% <ø> (ø) ⬆️
components/time-picker/time-holder.ts 95.61% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f89ea...a859427. Read the comment docs.

@vthinkxie vthinkxie merged commit 4c10e5b into NG-ZORRO:master Oct 23, 2019
chensimeng pushed a commit that referenced this pull request Nov 8, 2019
* feat(module:page-header): add `nzGhost` property

* chore: add config name cont

close #4303
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:page-header): add `nzGhost` property

* chore: add config name cont

close NG-ZORRO#4303
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:page-header): add `nzGhost` property

* chore: add config name cont

close NG-ZORRO#4303
@hsuanxyz hsuanxyz deleted the feat/page-header-redesigned branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants