Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:typography): support custom icons and tooltips #5911

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Oct 13, 2020

close #5888

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5888

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 13, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #5911 into master will increase coverage by 0.00%.
The diff coverage is 91.17%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5911   +/-   ##
=======================================
  Coverage   90.00%   90.01%           
=======================================
  Files         463      463           
  Lines       13986    14019   +33     
  Branches     2297     2305    +8     
=======================================
+ Hits        12588    12619   +31     
  Misses        854      854           
- Partials      544      546    +2     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/typography/typography.module.ts 100.00% <ø> (ø)
components/typography/text-copy.component.ts 94.73% <89.65%> (-5.27%) ⬇️
components/typography/text-edit.component.ts 97.50% <100.00%> (+0.06%) ⬆️
components/typography/typography.component.ts 97.79% <100.00%> (+0.06%) ⬆️
components/tooltip/base.ts 92.46% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846331e...e65e46c. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 2d4cbb0 into NG-ZORRO:master Oct 23, 2020
@hsuanxyz hsuanxyz deleted the feat/typography-tooltip branch October 23, 2020 13:49
@pr-triage pr-triage bot added the PR: merged label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typography] support configuration icons and tooltips
1 participant