Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown and autocomplete animations #6143

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

yangjunhan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6018

What is the new behavior?

Dropdown has open animation every time which triggers it. Autocompletion has close animation after clicking outside the input.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@yangjunhan yangjunhan changed the title fix: Fix dropdown and autocomplete animations fix: dropdown and autocomplete animations Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #6143 (6d2249c) into master (ddc7ded) will increase coverage by 0.00%.
The diff coverage is 95.45%.

❗ Current head 6d2249c differs from pull request most recent head 93713e4. Consider uploading reports for the commit 93713e4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6143   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         479      479           
  Lines       15319    15338   +19     
  Branches     2333     2338    +5     
=======================================
+ Hits        13772    13790   +18     
  Misses        930      930           
- Partials      617      618    +1     
Impacted Files Coverage Δ
components/dropdown/dropdown.directive.ts 88.57% <85.71%> (-0.21%) ⬇️
...ts/auto-complete/autocomplete-trigger.directive.ts 95.83% <100.00%> (+0.15%) ⬆️
components/auto-complete/autocomplete.component.ts 91.58% <100.00%> (+0.24%) ⬆️
components/dropdown/dropdown-menu.component.ts 85.29% <100.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc7ded...93713e4. Read the comment docs.

@yangjunhan yangjunhan force-pushed the fix-animation branch 3 times, most recently from cc6acc5 to 88ed617 Compare December 4, 2020 03:58
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there are some conflicts that need to be resolved, could you rebase onto master? thanks

@wenqi73 wenqi73 merged commit 70da5a2 into NG-ZORRO:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants