-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
potential changes to the parameter file (post API 22) #799
Comments
Copied over from #841 , to quote @rosiealice : "I am finding, following @walkeranthonyp's observations from MAAT, that the radiation code is sensitive to the number of diffuse radiation bins, which is currently 9. It would be useful, mostly to facilitate sensitivity analysis, for this to be modifiable via the parameter file. " fates/biogeophys/EDSurfaceAlbedoMod.F90 Line 418 in 7edf030
|
The crown damage module PR#788 introduces five new parameters.
fates_damage_frac = 0.01, 0.01, 0.01, 0.01, 0.01, 0.01, 0.01, 0.01, fates_damage_mort_p1 = 9.0,9.0,9.0,9.0,9.0,9.0,9.0,9.0,9.0,9.0,9.0,9.0 ; fates_damage_mort_p2 = 5.5, 5.5, 5.5, 5.5, 5.5, 5.5, 5.5, 5.5, 5.5, 5.5, fates_damage_recovery_scalar = 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, fates_history_damage_bins = 6 ; double fates_history_damage_bin_edges(fates_history_damage_bins) ; fates_history_damage_bin_edges = 0, 20, 40, 60, 80 100 ; @rgknox , I've added an additional parameter (sorry!) to the damage module that allows the timing of damage events to be set by the user, as in the logging module. double fates_damage_event_code ; fates_damage_event_code = 1 ; |
Here are potential new parameters for parteh_mode = 2 (ie the CNP model):
deafaults:
|
List of potential new parameters for the revised drought-deciduous phenology (pull request #801):
Default values:
There may be a couple of additional parameters in case I implement a photoperiod-based flushing approach for drought deciduous. |
Another thing is we should remove the "NOT USED" comments in the description names for the two variables https://github.com/NGEET/fates/blob/master/parameter_files/fates_params_default.cdl#L752-L757 |
As discussed at the meeting I can help with updating the metadata so that the description of the units is consistent. Note, I won't be changing the actual units of the parameters, just the metadata description. (e.g. m^2/m^2 ----> m2 m-2). |
In addition to vcmax_np1, vcmax_np2, vcmax_np3, vcmax_np4 listed above.....and also related to PR #768, the reviewers have noted that it would be cleaner in the code, and better for potentially future tuning, if a few more parameters would included in the parameter file. Below are new parameters to include that are related to the calculation of vcmax and jmax. (Let's also remove the "eca" from the parameter, as these are not necessarily only related to the ECA approach.) How about similar to fates_leaf_vcmax25top, we include the "leaf" indicator?
fates_leaf_vcmax_np1 = 4.02421875, 3.2345, 4.8, 3.878125, 4.8, 4.7175, fates_leaf_vcmax_np2 = 0.7640625, 0.7828125, 0.7453125, 0.9140625, 0.8015625, fates_leaf_vcmax_np3 = 0.07125, 0.08375, 0.08625, 0.19125, 0.12125, 0.185, fates_leaf_vcmax_np4 = 0.282, 0.282, 0.282, 0.282, 0.282, 0.282, 0.282,
The updated values for fates_leaf_flnr, still need to be gathered from the analysis by [Luo et al 2021].(https://www.nature.com/articles/s41467-021-25163-9). I can hopefully get these soon. |
started a branch to consolidate these, will eventually also include the maximum patch settings for both nat and anthro, as well as re-ordering code to pass maxpatch to CLM/ELM. https://github.com/rgknox/fates/tree/params-maxpatch-logfinal |
From external discussion with @sshu88
|
Let's use this space to generate our wish-list of updates to the parameter file.
From review of PR #736, @xuchongang suggested we consider adding the option to use gross assimilation in the conductance calculations, instead of net assimilation. As of #736, it is defined as a hard-coded logical at the top of the photosynthesis module "use_agross = .false.
From PR #768, we introduce parameters modify vcmax based on nutrient concentrations a la Walker et al.. This issue also takes over for #682
This PR is still a work in progress, and we are likely to add in a control parameter that switches this hypothesis on/off as well. Likewise, we may also add in other parameters as well via this PR.
Rename: "fates_fire_crown_depth_frac" to "fates_crown_depth_frac" as per #780
Add in a switch for the plant hydraulics solver: ie 1D taylor solve, 2D newton (deprecated) or 2D picard. Also, see #766
The text was updated successfully, but these errors were encountered: