Adding control of leaf water potential on transpiration through inner leaf humidity (Hydro only) #736
Conversation
|
|
||
| !!! Calculate anet, only exit iteration with negative anet when using anet in calculating gs | ||
| ! this is version B | ||
| anet = agross - lmr |
There was a problem hiding this comment.
I guess I am a bit confused about why this section on agross is in this PR? Is it allied to the modification of gs by LWP, or orthogonal to it? If it's a seperate issue, should it be in a separate PR?
There was a problem hiding this comment.
Sort of. If using lwp to constrain the transpiration, it is more appropriate to use agross instead of anet
| ! Parameters | ||
| ! ------------------------------------------------------------------------ | ||
| ! selection to use agross or anet in stomatal models, 1 - use agross, other values - use anet | ||
| integer,parameter :: use_agross = 1 |
There was a problem hiding this comment.
Can this part of the parameter file?
There was a problem hiding this comment.
will add this to next round of parameters for the wish-list
| real(r8) :: qs ! specific humidity at leaf surface | ||
| real(r8) :: qsat ! saturated specific humidity | ||
| real(r8) :: qsat_adj ! specific humidity adjusted by leaf water potential (g/kg) | ||
| real(r8) :: LWP_star ! leaf water potential scaling coefficient for inner leaf humidity |
There was a problem hiding this comment.
Can you mention what value of 0 or 1 means for a better understanding of the code?
| qsat = 0.622 * veg_esat / (can_press - 0.378 * veg_esat) | ||
| qsat_adj = qsat*LWP_star | ||
|
|
||
| if (k_lwp == 0 ) then |
There was a problem hiding this comment.
Since k_lwp is not an integer, it would be better to check if k_lwp is a very small number
There was a problem hiding this comment.
I was treating k_lwp as an positive integer in my mind when coding. Will adjust this.
There was a problem hiding this comment.
this has been updated and addressed
| ! then set stomata resistance to be very large to stop the transpiration or back flow of vapor | ||
| rstoma_out = rsmax0*100 | ||
| else | ||
| rstoma_out = (qsat-qs)*( 1/gstoma + rb)/(qsat_adj - qs)-rb |
There was a problem hiding this comment.
I personally do not like the add-on adjustment of leaf humidity on gs. I would prefer to updated the calculation of vpd (vapor pressure deficit from internal leave to air) or relative humidity (humidity in the air/humidity inside leave) for the two type of models. However, I think it is also justifiable as the above two models are fitted to air VPD assuming full saturation inside leaves. Not clear preference.....
remove the agross-anet option from this pull request, and put in a separate PR.
…lew away old leaf-humidity stuff in FatesPlantRespPhotosynthMod because of so many differences and conflicts. Will re-apply manually looking at original diff with base
|
Tests look good, only known fails, b4b with base. |
Description:
Issue #726
Collaborators:
Ryan Knox, Chonggang Xu, Charlie Koven
Expectation of Answer Changes:
StomaModification.pdf
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: