Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart fix for efflux variables #764

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Jul 16, 2021

Description:

Efflux is defined at the cohort scale. Efflux is passed from the cohort to the output flux to the HLMs litter pool before we perform disturbance and mortality. Thus, in order for restarts to work, this flux at the site level must be preserved prior to mortality and disturbance. Luckily, we can use the flux_diags structure which already exists to generate the output flux, this same flux will be preserved after a restart read.

Fixes: #763

Collaborators:

Expectation of Answer Changes:

This should not change results, because we don't yet generate efflux in any tests.

Checklist:

  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox
Copy link
Contributor Author

rgknox commented Jul 16, 2021

Including update to the pft index swapper tool.

@glemieux glemieux self-assigned this Sep 20, 2021
@rgknox
Copy link
Contributor Author

rgknox commented Oct 10, 2021

tested against baseline (temporary modification to ctsm5.1.dev056 that removes mosart tests from 1x1_brazil) :

fates-sci.1.47.1_api.17.0.0-ctsm5.1.dev056-RsFatesFix

Test results:
/glade/scratch/rgknox/tests_1010-122445ch

Expected DIFF against the base in: ERS_D_Ld30.f45_f45_mg37.I2000Clm50FatesCru.cheyenne_intel.clm-FatesPRT2

@rgknox rgknox merged commit 2edc895 into NGEET:master Oct 10, 2021
@rgknox rgknox deleted the efflux-restfix branch October 31, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FatesPFTIndexSwapper.py needs updating to api 16.1
2 participants