Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the name of the professor model values #76

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

diogotvf7
Copy link
Contributor

Switched the names from:

        professors.append({
            'professor_id': professor.id,
            'professor_acronym': professor.professor_acronym,
            'professor_name': professor.professor_name
        })

to:

        professors.append({
            'id': professor.id,
            'acronym': professor.professor_acronym,
            'name': professor.professor_name
        })

Copy link
Member

@DoStini DoStini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrible

Copy link
Member

@DoStini DoStini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved your approach! Great code 😀

@diogotvf7 diogotvf7 merged commit 61c99c0 into develop Apr 10, 2024
@diogotvf7 diogotvf7 deleted the fix/professor-endpoint-vals-names branch April 10, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants