New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the scope of spinlock is too large #60

Closed
techmotive opened this Issue Jul 31, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@techmotive

techmotive commented Jul 31, 2013

the spinlock "bib_session_lock" locks the whole f function that manipulate the sessions and bib, such as ipv6_udp, ipv4_udp, etc, which may cause performance problems in large connections condition.

@ghost ghost assigned ydahhrk Aug 1, 2013

@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Aug 1, 2013

Member

I remember I spent a while trying to figure how to address this some time ago.
The problem, as I recall, stems from the fact that all tables are inter-related by definition. Still, we might be able to pull something off now that we're more experienced.

Member

ydahhrk commented Aug 1, 2013

I remember I spent a while trying to figure how to address this some time ago.
The problem, as I recall, stems from the fact that all tables are inter-related by definition. Still, we might be able to pull something off now that we're more experienced.

@ydahhrk ydahhrk assigned dhfelix and unassigned ydahhrk Feb 20, 2014

@ydahhrk ydahhrk modified the milestones: 3.1.3, 3.1.1 Feb 20, 2014

dhfelix added a commit that referenced this issue Apr 3, 2014

an sneak peek of the issue #60, has a known bug which is in statics_r…
…outes.c that is on review, things to do: improved the javadoc for new and modified functions.

ydahhrk added a commit that referenced this issue Apr 24, 2014

Lots of revision on the issue #60 code.
Updated many comments, solved a couple of concurrence issues and
optimized some tree walks.

ydahhrk added a commit that referenced this issue Apr 25, 2014

Updating doc. Starting to wrap up for the release, and also issue #89.
The revision of #60 is getting out of control and we're already a
full week late, so we've decided to postpone it for 3.1.5.

@ydahhrk ydahhrk modified the milestones: 3.1.5, 3.1.4 Apr 25, 2014

@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Apr 25, 2014

Member

Moving to milestone 3.1.5 because the code's protection against race conditions still doesn't convince me.

Member

ydahhrk commented Apr 25, 2014

Moving to milestone 3.1.5 because the code's protection against race conditions still doesn't convince me.

@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Jun 24, 2014

Member

Fixed and collapsed to the master branch; closing.

Member

ydahhrk commented Jun 24, 2014

Fixed and collapsed to the master branch; closing.

@ydahhrk ydahhrk closed this Jun 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment