Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review nc:ConveyanceFuelCategoryAbstract #116

Closed
cdmgtri opened this issue Feb 20, 2020 · 4 comments
Closed

Review nc:ConveyanceFuelCategoryAbstract #116

cdmgtri opened this issue Feb 20, 2020 · 4 comments

Comments

@cdmgtri
Copy link
Collaborator

cdmgtri commented Feb 20, 2020

j:EngineType contains element nc:ConveyanceFuelCategoryAbstract. This element has substitutions for a text element, an AMMVA D20 code, and a NDEX code. This element is in the wrong spot or has the wrong name.

Current

j:EngineType

  • j:EngineCylinderQuantity
  • j:EngineID
  • nc:ConveyanceFuelCategoryAbstract
  • j:EngineDisplacementMeasure
  • j:EngineHorsepowerQuantity

Options

  1. Leave the element under j:EngineType and change the name and namespace to j:EngineFuelCategoryAbstract
  2. Move the element to j:ConveyanceAugmentationType and move it to the Justice namespace (j:ConveyanceFuelCategoryAbstract)
  3. Move the element to nc:ConveyanceType and leave the name as is (nc:ConveyanceFuelCategoryAbstract)
@cdmgtri
Copy link
Collaborator Author

cdmgtri commented Feb 25, 2020

After checking with subject matter experts from the FBI (they no longer track this field) and AAMVA (they currently track fuel category at the conveyance/vehicle level), recommend leaving the element name as is and moving it to nc:ConveyanceType (Option 3).

@cdmgtri cdmgtri modified the milestones: niem-5.0alpha1, niem-5.0beta1 Mar 23, 2020
@sptws001
Copy link

sptws001 commented Mar 24, 2020

I agree with moving to nc:ConveyanceType.
I would argue that since propulsion type (engine, sail, etc.) and engine properties (where propulsion type is engine) are features of conveyance, the entire j:EngineType and substitutions are candidates for core (nc:ConveyanceType, nc:VehicleType).

@cdmgtri
Copy link
Collaborator Author

cdmgtri commented Mar 24, 2020

The Harmonization Workgroup recommends moving nc:ConveyanceFuelCategoryAbstract to nc:ConveyanceType.

Further changes to engines and fuel categories may be necessary at some point. The current modeling fulfills the currently known requirements, but can be reconsidered if additional requirements are submitted.

@cdmgtri
Copy link
Collaborator Author

cdmgtri commented Jul 1, 2020

Updated in the 5.0 beta.

@cdmgtri cdmgtri closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants