moves exit_UIP() from UIP.py to utils/utils.py #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thank you for your Patch make sure you have the right commit structure that is Also please upload a screenshot if you have made changes to the gui. |
| """Exit from UIP program.""" | ||
| pid_file = os.path.join(HOME_DIR, 'daemon-uip.pid') | ||
| if os.path.exists(pid_file): | ||
| send(pid_file, SIGTERM) |
There was a problem hiding this comment.
need to import send in this file
SACHIN-13
force-pushed
the
new-feature
branch
2 times, most recently
from
07181ca
to
7bd9463
Compare
| @@ -3,12 +3,14 @@ | |||
| import sys | |||
| import os | |||
|
|
|||
| from daemoniker import Daemonizer, send, SIGTERM | |||
| from daemoniker import Daemonizer | |||
| from daemoniker import SIGTERM | |||
There was a problem hiding this comment.
no need for these here right?
|
|
|
Both work
…On 25-Jan-2017 10:06 PM, "Naveen Kumar Sangi" ***@***.***> wrote:
SIGSTOP could be used in conjunction, right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIIwPzEBWLlCSSuAGAgyzP4MJXXfc_TXks5rV3nzgaJpZM4LtTer>
.
|
|
I mean like, we could use |
|
But why would we want that? There's a reason this function is exit_uip
right?
…On 25-Jan-2017 10:07 PM, "Naveen Kumar Sangi" ***@***.***> wrote:
I mean like, we could use SIGSTOP and resume later, right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIIwP0PHZISzKK-BtCO8DVTVEgxW4VbCks5rV3pHgaJpZM4LtTer>
.
|
SACHIN-13
force-pushed
the
new-feature
branch
2 times, most recently
from
c9896c3
to
c2fd74d
Compare
|
@SACHIN-13 Please amend your commit according to contribution guidelines. |
| @@ -3,12 +3,13 @@ | |||
| import sys | |||
| import os | |||
|
|
|||
| from daemoniker import Daemonizer, send, SIGTERM | |||
| from daemoniker import Daemonizer | |||
| from daemoniker import send | |||
SACHIN-13
force-pushed
the
new-feature
branch
2 times, most recently
from
bb58a46
to
5e2073f
Compare
SACHIN-13
force-pushed
the
new-feature
branch
from
5e2073f
to
c6583af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #340