-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moves exit_UIP() from UIP.py to utils/utils.py #342
Conversation
Hi thank you for your Patch make sure you have the right commit structure that is
Also please upload a screenshot if you have made changes to the gui. |
"""Exit from UIP program.""" | ||
pid_file = os.path.join(HOME_DIR, 'daemon-uip.pid') | ||
if os.path.exists(pid_file): | ||
send(pid_file, SIGTERM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to import send
in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also SIGTERM
07181ca
to
7bd9463
Compare
@@ -3,12 +3,14 @@ | |||
import sys | |||
import os | |||
|
|||
from daemoniker import Daemonizer, send, SIGTERM | |||
from daemoniker import Daemonizer | |||
from daemoniker import SIGTERM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for these here right?
|
Both work
…On 25-Jan-2017 10:06 PM, "Naveen Kumar Sangi" ***@***.***> wrote:
SIGSTOP could be used in conjunction, right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIIwPzEBWLlCSSuAGAgyzP4MJXXfc_TXks5rV3nzgaJpZM4LtTer>
.
|
I mean like, we could use |
But why would we want that? There's a reason this function is exit_uip
right?
…On 25-Jan-2017 10:07 PM, "Naveen Kumar Sangi" ***@***.***> wrote:
I mean like, we could use SIGSTOP and resume later, right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIIwP0PHZISzKK-BtCO8DVTVEgxW4VbCks5rV3pHgaJpZM4LtTer>
.
|
c9896c3
to
c2fd74d
Compare
@SACHIN-13 Please amend your commit according to contribution guidelines. |
@@ -3,12 +3,13 @@ | |||
import sys | |||
import os | |||
|
|||
from daemoniker import Daemonizer, send, SIGTERM | |||
from daemoniker import Daemonizer | |||
from daemoniker import send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still left :P
bb58a46
to
5e2073f
Compare
5e2073f
to
c6583af
Compare
fixes: #340