Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arxiv API support #11

Merged
merged 2 commits into from
Mar 1, 2022
Merged

arxiv API support #11

merged 2 commits into from
Mar 1, 2022

Conversation

ksilo
Copy link

@ksilo ksilo commented Feb 20, 2022

Hey, trying to make a contribution to this project. Will be happy if you could review and make suggestions how can I improve it.

Copy link
Member

@stijnh stijnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is really great work, thanks for your contribution. Support for ArXiv is indeed a major contribution for the project. I am happy to see the work that you put into this.

I have reviewed your pull requests, see the code review.

Here are some general points:

  • Add search_arxiv to sources/__init__.py so its available directly as litstudy.search_arxiv
  • The dependency feedparser should be added to setup.cfg
  • The Document class has bunch of methods that can be overriden. Do you think there are more that are provided by the ArXiv API? (Maybe abstract, keywords, or language)?

litstudy/sources/arxiv.py Outdated Show resolved Hide resolved
litstudy/sources/arxiv.py Show resolved Hide resolved
litstudy/sources/arxiv.py Outdated Show resolved Hide resolved
litstudy/sources/arxiv.py Outdated Show resolved Hide resolved
litstudy/sources/arxiv.py Show resolved Hide resolved
litstudy/sources/arxiv.py Outdated Show resolved Hide resolved
litstudy/sources/arxiv.py Outdated Show resolved Hide resolved
@ksilo ksilo requested a review from stijnh February 24, 2022 20:25
@stijnh
Copy link
Member

stijnh commented Mar 1, 2022

Thanks for the work! Looks good! I'll merge this and it'll be part of the next release of litstudy.

@stijnh stijnh closed this Mar 1, 2022
@stijnh stijnh reopened this Mar 1, 2022
@stijnh stijnh merged commit 3cfea1d into NLeSC:master Mar 1, 2022
@ksilo ksilo deleted the ksilo-arxiv-feature branch March 2, 2022 13:07
@stijnh stijnh mentioned this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants