Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no longer needed 'always_recover_data' function #1086

Closed
timbru opened this issue Jun 26, 2023 · 0 comments · Fixed by #1117
Closed

Remove no longer needed 'always_recover_data' function #1086

timbru opened this issue Jun 26, 2023 · 0 comments · Fixed by #1117

Comments

@timbru
Copy link
Contributor

timbru commented Jun 26, 2023 •
edited
Loading

This is no longer required now that the transactionality of changes is much improved: #1067, #1078, #1076, #1077, #1085, #1108, #1090.

In particular, #1078 ensures we cannot have partially written change sets. So, the recovery function that we had no longer makes sense.
@timbru timbru mentioned this issue Jul 7, 2023
Merged
@timbru timbru changed the title Fix 'always_recover_data' function to check all data, or remove it. Remove 'always_recover_data' function Sep 22, 2023
@timbru timbru changed the title Remove 'always_recover_data' function Remove no longer needed 'always_recover_data' function Sep 22, 2023
timbru pushed a commit that referenced this issue Sep 22, 2023
Remove no longer needed 'always_recover_data' function #1086
60b8d36
@timbru timbru linked a pull request Sep 22, 2023 that will close this issue
Remove no longer needed 'always_recover_data' function #1086 #1117
Merged
timbru pushed a commit that referenced this issue Sep 27, 2023
Remove no longer needed 'always_recover_data' function #1086
222255f
@timbru timbru closed this as completed Sep 27, 2023
timbru pushed a commit that referenced this issue Oct 17, 2023
Remove no longer needed 'always_recover_data' function #1086
c907478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
0.14.x
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove no longer needed 'always_recover_data' function #1086 NLnetLabs/krill
1 participant
@timbru