Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding the TA manifest number. #1178

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Allow overriding the TA manifest number. #1178

merged 2 commits into from
Jun 11, 2024

Conversation

timbru
Copy link
Contributor

@timbru timbru commented Dec 19, 2023

Allows overriding the initial manifest number, either by specifying --initial_manifest_number if the CLI is used to initialise the TA signer, or by including ta_mft_nr_override: #nr in the ImportTa JSON.

Allows overriding the TA manifest number when signing a TA proxy request by specifying --ta_mft_number_override in the CLI.

@partim partim requested a review from ximon18 June 11, 2024 14:14
ximon18
ximon18 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@ximon18 ximon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been used and no issues were reported.

@partim partim merged commit 244e71c into main Jun 11, 2024
18 checks passed
@partim partim deleted the ta-manifest-extras branch June 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximon18 ximon18 ximon18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timbru @ximon18 @partim