Fix locking when downloading RIS dump files (#1177) #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
added a commit
that referenced
this pull request
Jun 21, 2024
New * Allow overriding the initial manifest number when initializing the TA signer, either by specifying `--initial_manifest_number` in the CLI or by including `ta_mft_nr_override: #nr` in the `ImportTa` JSON. ([#1178]) * Allow overriding the TA manifest number when signing a TA proxy request by specifying `--ta_mft_number_override` in the CLI. ([#1178]) Bug fixes * Prevent empty RRDP delta lists to be produced. ([#1181]) * Correctly encode empty revocation lists in CRLs. (via [rpki-rs#295]) * Allow read access to the RIS dump while downloading a new dump. ([#1179]) * Don’t apply “child revoke key” command if the resource class does not exist. ([#1208]) Other changes * The minimum supported Rust version is now 1.70.0. ([#1198])
partim
added a commit
that referenced
this pull request
Jun 27, 2024
New * Allow overriding the initial manifest number when initializing the TA signer, either by specifying `--initial_manifest_number` in the CLI or by including `ta_mft_nr_override: #nr` in the `ImportTa` JSON. ([#1178]) * Allow overriding the TA manifest number when signing a TA proxy request by specifying `--ta_mft_number_override` in the CLI. ([#1178]) Bug fixes * Prevent empty RRDP delta lists to be produced. ([#1181]) * Correctly encode empty revocation lists in CRLs. (via [rpki-rs#295]) * Allow read access to the RIS dump while downloading a new dump. ([#1179]) * Don’t apply “child revoke key” command if the resource class does not exist. ([#1208]) Other changes * The minimum supported Rust version is now 1.70.0. ([#1198])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue observed in #1177.
The code locked the 'seen' announcements while downloading new RIR dump files. This prevented read access to the announcement during download. This change postpones getting the write lock until after the download is completed, so it only keeps it for the shortest possible time.