NSD zone verifier logging prefix

[wtoorop]

The NSD zone verifier logs all output via syslog, but there is little or no indication what log output comes from NSD itself and the validator. Can some sort of prefix be added?

(requested by @jschlyter )

[jschlyter]

I guess this will be implemented at https://github.com/NLnetLabs/nsd/blob/master/verify.c#L122 ?

[wtoorop]

I guess this will be implemented at https://github.com/NLnetLabs/nsd/blob/master/verify.c#L122 ?

Indeed! What are you thinking, a configurable prefix?

[jschlyter]

I guess this will be implemented at https://github.com/NLnetLabs/nsd/blob/master/verify.c#L122 ?

Indeed! What are you thinking, a configurable prefix?

Just verify-stdout: or similar is good. other verifier ops are logged as verify: it seems.

[johanix]

Including the zone name could be useful. Obviously someone that writes their own verifier can easily do that in the verifier. But the usefulness of the prefix is

• When using standard tools for verification
• For the case where the verifier crashes and you'd like to know zone triggered the crash.

Johan

[jschlyter]

@wtoorop do you want a PR?

[wtoorop]

@wtoorop do you want a PR?

I think something configurable would fit all situations best. Maybe with some string processing similar as with the zonefile option (i.e. %s is replaced with the zone name etc.)
If you want to give that a shot, then a PR will be appreciated yes. Otherwise I'll just do it when there is a free moment...

[k0ekk0ek]

Thought I'd tackle this one while I was at it. Chose to prefix messages with verifier: , which fits the other messages nicely (IMHO)

[jschlyter]

You want the prefix for all lines, both first and continuation, I assume.

[k0ekk0ek]

@jschlyter, indeed 😅. Oversight on my part.