-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing AC_SUBST(dbdir) breaks installation with 4.8.0 #306
Comments
Thank you for the report! That escaped notice, the fix is to remove it from Makefile.in, since it is no longer used. The configure option is printed to inform the user in the help output and backwards compatibility, but there is no need for database directory or file. The commit removes the creation of the Apart from briefly creating a spurious |
The additional commit fixes that for the |
Commit 526a8ce removed the
--with-dbfile
option fromconfigure.ac
. However, it accidentally removedAC_SUBST(dbdir)
as well - so the use of@dbdir@
inMakefile.in
won't get expanded. This will causemake install
to either fail or create a nonsense directory.Adding
AC_SUBST(dbdir)
fixes it, but since there's no guarantee that any files will end up there now, it may be better to removedbdir
fromMakefile.in
entirely?It'd also be a good idea to test
make install
as part of the release process.The text was updated successfully, but these errors were encountered: