Limit peek_all to return data up until self.len #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
approved these changes
Aug 30, 2023
partim
added a commit
that referenced
this pull request
Oct 18, 2023
Breaking changes * Change the lifetime of the range for a reference to the lifetime of the reference. ([#41] by [@xofyarg]) * Explicitly re-export select items at crate level rather than wildcard export everything. ([#39]) New * Adds a `BuilderAppendError<_>` type alias that simplifies trait bounds for complex `FromBuilder` trait bounds. ([#38]) Bug fixes * Fix `Parser::peek_all` to only return data up until the parser's length rather than all data. ([#40])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new
Parserby calling.parse_parser(some_len)on an existingParser, the new parser has a limited view over the same octets as the old parser. This limit (self.len) was however not respected by thepeek_all()method, possibly returning an unexpectedly large slice.