Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rust to 1.32 and alpine to 3.9 for dockerfile freshness #61

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

wk
Copy link
Contributor

@wk wk commented Feb 3, 2019

Since the rust language is a relatively fast moving project, keeping the artifact build process up with rust's latest is likely to be beneficial and prevent new commits which make use of new language features from breaking the build.

Outright relying on rust:latest for the build, however, could break the build process due to deprecation, or introduce bugs that affect only the docker artifact.

Thus, a compromise in the form of a lightly-tested manual bump to the current latest (1.32.0) instead.

@partim
Copy link
Member

partim commented Feb 3, 2019

We actually have an officially supported minimal Rust version (currently 1.30) and there is a Travis build on that. However, in 1.32 Rust switched to the system allocator for smaller binary sizes, so this is a good idea, anyway.

Which also reminds me that I wanted to do an allocator shootout for Routinator ...

@partim partim merged commit b9a5adb into NLnetLabs:master Feb 3, 2019
@wk
Copy link
Contributor Author

wk commented Feb 3, 2019

Didn't realize how much of a difference that makes! Last build on 1.30.1:
-rwxr-xr-x 1 root root 10036688 Feb 1 12:54 /usr/local/bin/routinator
Test build on 1.32.0:
-rwxr-xr-x 1 root root 7119488 Feb 3 11:57 /usr/local/bin/routinator

Very cool! Thanks for the heads up!

@wk wk deleted the bump-docker-env branch February 3, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants