-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLV removal #284
DLV removal #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I especially like the warnings for the configuration options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val_stub_noroot.rpl
still sets a dlv-anchor
. No big deal as it is not needed for the test to succeed.
No other comments, looks good to me.
Thanks for the reviews, fixed the comments and merged it. |
* nlnet/master: (37 commits) - Fix NLnetLabs#296: systemd nss-lookup.target is reached before unbound can successfully answer queries. Changed contrib/unbound.service.in. - Refactor to use sock_strerr shorthand function. - Merge PR NLnetLabs#293: Add missing prototype. Also refactor to use the new shorthand function to clean up the code. Add missing prototype. - Review fix, doxygen and assign null in case of error free. Please doxygen, quote the characters to stop it from parsing a doxygen command. - Similar to NSD PR#113, implement that interface names can be used, eg. something like interface: eth0 is resolved at server start and uses the IP addresses for that named interface. - Update documentation in python example code. - Change configure to use EVP_sha256 instead of HMAC_Update for openssl-3.0.0. - Fix to apply chroot to dnstap-socket-path, if chroot is enabled. - Fix that dnstap reconnects do not spam the log with the repeated attempts. Attempts on the timer are only logged on high verbosity, if they produce a connection failure error. - Fix stats double count issue (NLnetLabs#289). - Create and init edns tags data for libunbound. Changelog note. - Rerun autoconf Rerun autoconf and autoheader on configure.ac, with libtool Add changlog entry for PR NLnetLabs#277. - Check for existence 'EVP_MAC_CTX_set_params' function (openssl >= 3.0.0-alpha5) - Fix NLnetLabs#287: doc typo: "Additionaly". Changelog note for NLnetLabs#246 and NLnetLabs#284 - Merge PR NLnetLabs#284 and Fix NLnetLabs#246: Remove DLV entirely from Unbound. The DLV has been decommisioned and in unbound 1.5.4, in 2015, there was advise to stop using it. The current code base does not contain DLV code any more. The use of dlv options displays a warning. dlv removal, remove DLV reference from unused use in test case. ...
This set of commits removes DLV support from Unbound. DLV has been decommissioned and we advised to stop using it, now it is removed. The config options for it print a warning.