Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prototype. #293

merged 1 commit into from Aug 31, 2020


Copy link

@fobser fobser commented Aug 28, 2020

sock_close() is currently unused so it might be better to remove the function in listen_dnsport.c

@wcawijngaards wcawijngaards merged commit 01bfd3f into NLnetLabs:master Aug 31, 2020
wcawijngaards added a commit that referenced this pull request Aug 31, 2020
Copy link

wcawijngaards commented Aug 31, 2020

Thanks fobser! I have merged this, then moved it to net_help.h and refactored the code to use the new function, it is much shorter, with less #ifdefs in the code.

jedisct1 added a commit to jedisct1/unbound that referenced this pull request Sep 2, 2020
* nlnet/master: (37 commits)
  - Fix NLnetLabs#296: systemd is reached before unbound can   successfully answer queries. Changed contrib/
  - Refactor to use sock_strerr shorthand function.
  - Merge PR NLnetLabs#293: Add missing prototype.  Also refactor to use the new   shorthand function to clean up the code.
  Add missing prototype.
  - Review fix, doxygen and assign null in case of error free.
  Please doxygen, quote the characters to stop it from parsing a doxygen command.
  - Similar to NSD PR#113, implement that interface names can be used,   eg. something like interface: eth0 is resolved at server start and   uses the IP addresses for that named interface.
  - Update documentation in python example code.
  - Change configure to use EVP_sha256 instead of HMAC_Update for   openssl-3.0.0.
  - Fix to apply chroot to dnstap-socket-path, if chroot is enabled.
  - Fix that dnstap reconnects do not spam the log with the repeated   attempts.  Attempts on the timer are only logged on high verbosity,   if they produce a connection failure error.
  - Fix stats double count issue (NLnetLabs#289).
  - Create and init edns tags data for libunbound.
  Changelog note. 	- Rerun autoconf
  Rerun autoconf and autoheader on, with libtool
  Add changlog entry for PR NLnetLabs#277.
  - Check for existence 'EVP_MAC_CTX_set_params' function (openssl >=    3.0.0-alpha5)
  - Fix NLnetLabs#287: doc typo: "Additionaly".
  Changelog note for NLnetLabs#246 and NLnetLabs#284 - Merge PR NLnetLabs#284 and Fix NLnetLabs#246: Remove DLV entirely from Unbound.   The DLV has been decommisioned and in unbound 1.5.4, in 2015, there   was advise to stop using it.  The current code base does not contain   DLV code any more.  The use of dlv options displays a warning.
  dlv removal, remove DLV reference from unused use in test case.
@fobser fobser deleted the missing-prototype branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants