Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link error when OpenSSL is configured with no-engine (GH #175) #176

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fix link error when OpenSSL is configured with no-engine (GH #175) #176

merged 1 commit into from
Mar 2, 2020
+3 −1

Conversation

noloader
Copy link
Contributor

@noloader noloader commented Feb 29, 2020 •
edited
Loading

Also see Issue 175, .libs/unitmain.o:unitmain.c:function main: error: undefined reference to 'ENGINE_cleanup'.

I believe a new configure should be generated if this PR is accepted.

@noloader noloader mentioned this pull request Feb 29, 2020
Closed
@noloader noloader changed the title Fix link error on Android when OpenSSL is configured with no-engine (GH #175) Fix link error when OpenSSL is configured with no-engine (GH #175) Mar 1, 2020
@ralphdolmans ralphdolmans merged commit 75a2a05 into NLnetLabs:master Mar 2, 2020
ralphdolmans added a commit that referenced this pull request Mar 2, 2020
@ralphdolmans
- Add github reference in changelog (Fix #175, Merge PR #176)
868ce63
@ralphdolmans
Copy link
Contributor

Thanks! We already had a check for ENGINE_cleanup in daemon.c. I merged that check with the one you provided, for both daemon.c and unitmain.c

@noloader noloader deleted the openssl branch March 2, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noloader @ralphdolmans