TCP race condition #612
Merged
TCP race condition #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flow to prevent race conditions.
cb_and_decommission stage to signal later code about their state; prevents premature item deletion.
wcawijngaards
approved these changes
Jan 25, 2022
gthess
added a commit
that referenced
this pull request
Jan 25, 2022
- Merge PR #612: TCP race condition.
|
Thanks! |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 25, 2022
* nlnet/master: Changelog note for NLnetLabs#612: - Merge PR NLnetLabs#612: TCP race condition. - Fix NLnetLabs#588: Unbound 1.13.2 crashes due to p->pc is NULL in serviced_udp_callback. - Better bookkeeping when reclaiming the TCP buffer. - Mark waiting_tcp and serviced_query as being in the cb_and_decommission stage to signal later code about their state; prevents premature item deletion. Changelog note for NLnetLabs#610 - Fix NLnetLabs#610: Undefine-shift in sldns_str2wire_hip_buf. - Fix NLnetLabs#610: Undefine-shift in sldns_str2wire_hip_buf. - Add serviced_query timer to send upstream queries outside of the mesh flow to prevent race conditions. - For dnstap, do not wakeupnow right there. Instead zero the timer to force the wakeup callback asap. - For NLnetLabs#602: Allow the module-config "subnetcache validator cachedb iterator". - Add rpz: for-downstream: yesno option, where the RPZ zone is authoritatively answered for, so the RPZ zone contents can be checked with DNS queries directed at the RPZ zone. Changelog note for NLnetLabs#605: - Merge PR NLnetLabs#605: Fix EDNS to upstream where the same option could be attached more than once. - Make sure callback changes for EDNS are not lost. - Fix EDNS to upstream where the same option could be attached more than once. - Add a region to serviced_query for allocations.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to TCP in an attempt to fix race condition bugs.
It relates to #411, #537, #469, #588 and #432.