Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP race condition #612

Merged
merged 3 commits into from
Jan 25, 2022
Merged

TCP race condition #612

merged 3 commits into from
Jan 25, 2022

Conversation

gthess
Copy link
Member

@gthess gthess commented Jan 25, 2022

This PR introduces changes to TCP in an attempt to fix race condition bugs.

It relates to #411, #537, #469, #588 and #432.

  cb_and_decommission stage to signal later code about their state;
  prevents premature item deletion.
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I see no problems with this.

@gthess gthess merged commit ddc3c75 into master Jan 25, 2022
@gthess gthess deleted the tcp-race-condition branch January 25, 2022 16:26
gthess added a commit that referenced this pull request Jan 25, 2022
- Merge PR #612: TCP race condition.
@gthess
Copy link
Member Author

gthess commented Jan 25, 2022

Thanks!

jedisct1 added a commit to jedisct1/unbound that referenced this pull request Jan 25, 2022
* nlnet/master:
  Changelog note for NLnetLabs#612: - Merge PR NLnetLabs#612: TCP race condition.
  - Fix NLnetLabs#588: Unbound 1.13.2 crashes due to p->pc is NULL in   serviced_udp_callback.
  - Better bookkeeping when reclaiming the TCP buffer.
  - Mark waiting_tcp and serviced_query as being in the   cb_and_decommission stage to signal later code about their state;   prevents premature item deletion.
  Changelog note for NLnetLabs#610 - Fix NLnetLabs#610: Undefine-shift in sldns_str2wire_hip_buf.
  - Fix NLnetLabs#610: Undefine-shift in sldns_str2wire_hip_buf.
  - Add serviced_query timer to send upstream queries outside of the mesh   flow to prevent race conditions.
  - For dnstap, do not wakeupnow right there. Instead zero the timer to   force the wakeup callback asap.
  - For NLnetLabs#602: Allow the module-config "subnetcache validator cachedb   iterator".
  - Add rpz: for-downstream: yesno option, where the RPZ zone is   authoritatively answered for, so the RPZ zone contents can be   checked with DNS queries directed at the RPZ zone.
  Changelog note for NLnetLabs#605: - Merge PR NLnetLabs#605: Fix EDNS to upstream where the same option could be   attached more than once.
  - Make sure callback changes for EDNS are not lost.
  - Fix EDNS to upstream where the same option could be attached more than   once. - Add a region to serviced_query for allocations.
@gthess gthess mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants