Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make install-lib make target install the pkg-config file. #644

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Make install-lib make target install the pkg-config file. #644

merged 1 commit into from
Mar 9, 2022

Conversation

FGasper
Copy link
Contributor

@FGasper FGasper commented Mar 8, 2022

Issue #643

wcawijngaards
wcawijngaards approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The finish operation acts on the library binary, so I would keep those lines together. But it works regardless.

@wcawijngaards wcawijngaards merged commit 79f8fc1 into NLnetLabs:master Mar 9, 2022
wcawijngaards added a commit that referenced this pull request Mar 9, 2022
@wcawijngaards
Changelog note for #644, move commands together for library binary.
b0dbfa3
@wcawijngaards
Copy link
Member

Thanks for the fix! Merged it into the repository.

@FGasper FGasper deleted the issue_643_pkgconfig_install_lib branch March 10, 2022 13:51
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Mar 14, 2022
@jedisct1
Merge remote-tracking branch 'nlnet/master'
c5ad632 
* nlnet/master: (27 commits)
  Changelog note for NLnetLabs#644, move commands together for library binary.
  Make `install-lib` make target install the pkg-config file.
  - Fix configure for python to use sysutils, because distutils is   deprecated. It uses sysutils when available, distutils otherwise.
  - Fix for NLnetLabs#637: fix integer overflow checks in sldns_str2period.
  - Fix NLnetLabs#637: Integer Overflow in sldns_str2period function.
  - Fix compile warnings for printf ll format on mingw compile.
  - Various fixes for NLnetLabs#632: variable initialisation, convert the qinfo   to str once, accept trailing dot in the local-zone ipset option.
  Changelog entry for NLnetLabs#632 - Merge PR NLnetLabs#632 from scottrw93: Match cnames in ipset.
  - Added tests for ipset.
  - Fix pythonmod for change in iter_dp_is_useless function prototype.
  - Fix for edns client subnet option add fix in removal code, from review.
  - Fix edns client subnet to add the option based on the option list,   so that it is not state dependent, after the state fix of NLnetLabs#605 for   double EDNS options.
  Changelog entry for NLnetLabs#623: - Merge NLnetLabs#623 from rex4539: Fix typos.
  - Fix NLnetLabs#630: Unify the RPZ log messages.
  - Fix for NLnetLabs#633: updated fix with new text.
  - Fix NLnetLabs#633: Document unix domain socket support for unbound-control.
  - Fix check interface existence for support detection in remote lookup.
  - update Makefile dependencies.
  - Fix to detect that no IPv6 support means that IPv6 addresses are   useless for delegation point lookups.
  Match cnames in ipset
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FGasper @wcawijngaards