Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed null-reference-exception when parsing empty scope-property collection #233

Merged
merged 2 commits into from
Aug 3, 2018

Conversation

snakefoot
Copy link
Contributor

Fixed bug introduced with #232

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #233 into master will decrease coverage by 1.2%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   71.82%   70.61%   -1.21%     
==========================================
  Files           7        7              
  Lines         433      439       +6     
  Branches      106      108       +2     
==========================================
- Hits          311      310       -1     
- Misses         80       87       +7     
  Partials       42       42
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 77.45% <ø> (ø) ⬆️
...og.Extensions.Logging/Logging/NLogLoggerFactory.cs 0% <0%> (ø) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 75% <0%> (-7.5%) ⬇️
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 67.34% <20%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda6a7a...9c7decf. Read the comment docs.

@304NotModified
Copy link
Member

enhancement, because the bug was never released

@304NotModified 304NotModified added this to the 1.2.1 milestone Aug 3, 2018
@304NotModified 304NotModified self-requested a review August 3, 2018 14:13
@304NotModified
Copy link
Member

I did recognize some changes as a result of Sonar(lint) ;)

Thanks!

@304NotModified 304NotModified merged commit 0547d70 into NLog:master Aug 3, 2018
@snakefoot
Copy link
Contributor Author

@304NotModified I did recognize some changes as a result of Sonar :)

Yes like code analysis tools. Though not always code complexity analysis tools :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants