NLogMessageParameterList - Reduce code complexity for IsValidParameterList #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
3 times, most recently
from
257b77f
to
fa66951
Compare
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=========================================
- Coverage 81.98% 81.88% -0.1%
=========================================
Files 12 12
Lines 1110 1104 -6
Branches 195 193 -2
=========================================
- Hits 910 904 -6
Misses 136 136
Partials 64 64
Continue to review full report at Codecov.
|
snakefoot
force-pushed
the
LoggerBuilderAddNLogLifetime
branch
from
fa66951
to
6a188d8
Compare
| if (!isPositional && i != 0) | ||
| isMixedPositional = true; | ||
| if (!isPositional) | ||
| isMixedPositional = i != 0; |
There was a problem hiding this comment.
The semantics changed here. Is that on purpose?
There was a problem hiding this comment.
Yes the result is the same. But one less condition.
| { | ||
| hasMessageTemplateCapture = true; | ||
| } | ||
| isMixedPositional = isPositional; |
There was a problem hiding this comment.
Yes the result is the same. But less conditions.
Yes while keeping performance |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd try :)