Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarQube Scanning #494

Merged
merged 9 commits into from
Mar 26, 2021
Merged

Fix SonarQube Scanning #494

merged 9 commits into from
Mar 26, 2021

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Mar 24, 2021

msbuild-sonarqube-runner is deprecated

trying to fix #492

@304NotModified 304NotModified changed the title Upgrade sonarscanner Fix SonarQube Scanning Mar 24, 2021
@304NotModified 304NotModified added this to the 1.7.2 milestone Mar 24, 2021
@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #494 (8f8f2aa) into master (a047ac1) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   81.25%   80.96%   -0.29%     
==========================================
  Files          15       16       +1     
  Lines        1296     1345      +49     
  Branches      223      234      +11     
==========================================
+ Hits         1053     1089      +36     
- Misses        165      172       +7     
- Partials       78       84       +6     
Impacted Files Coverage Δ
.../LayoutRenderers/MicrosoftConsoleLayoutRenderer.cs 73.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a047ac1...8f8f2aa. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 24, 2021
@304NotModified
Copy link
Member Author

I seems the branch needs to passed, as it's all on master

@304NotModified
Copy link
Member Author

@304NotModified 304NotModified marked this pull request as draft March 24, 2021 23:17
@pull-request-size pull-request-size bot added size/S and removed size/M labels Mar 26, 2021
@304NotModified 304NotModified modified the milestones: 1.7.2, 1.7.3 Mar 26, 2021
@304NotModified 304NotModified marked this pull request as ready for review March 26, 2021 21:10
@304NotModified 304NotModified enabled auto-merge (squash) March 26, 2021 21:11
@304NotModified
Copy link
Member Author

branch analysis is now good, PR not (reported to master)

image

@304NotModified 304NotModified marked this pull request as draft March 26, 2021 21:21
@304NotModified
Copy link
Member Author

Docs: https://docs.sonarqube.org/latest/analysis/pull-request/

Parameter Name Description
sonar.pullrequest.key Unique identifier of your Pull Request. Must correspond to the key of the Pull Request in your ALM.e.g.: sonar.pullrequest.key=5
sonar.pullrequest.branch The name of the branch that contains the changes to be merged.e.g.: sonar.pullrequest.branch=feature/my-new-feature
sonar.pullrequest.base The branch into which the Pull Request will be merged.Default: mastere.g.: sonar.pullrequest.base=master

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 26, 2021
@304NotModified
Copy link
Member Author

304NotModified commented Mar 26, 2021

now good:

image

@304NotModified 304NotModified marked this pull request as ready for review March 26, 2021 22:00
@304NotModified 304NotModified enabled auto-merge (squash) March 26, 2021 22:00
@304NotModified 304NotModified merged commit 084cd50 into master Mar 26, 2021
@304NotModified 304NotModified deleted the upgrade-sonar-scanner branch March 26, 2021 22:18
@snakefoot
Copy link
Contributor

Looks like it has caused some "security issues" to become unresolved on the NLog-project:

https://sonarcloud.io/project/security_hotspots?branch=dev&id=nlog2

@304NotModified
Copy link
Member Author

It's the SonarQube update itself I guess, will check it

@304NotModified
Copy link
Member Author

@snakefoot doubting about this one:

https://sonarcloud.io/project/security_hotspots?branch=dev&id=nlog2#

It's because if the [Serializable]. What do you think?

@snakefoot
Copy link
Contributor

snakefoot commented Mar 29, 2021

No idea. Marked NestedContext as obsolete with NLog 5.0, because injecting "custom" types into remoting-context gives issues on all applications called using the obsolete remoting-protocol (Did not know this when implementing NDLC for NLog). Avoiding isuses with application using NLog NDLC that calls other application that doesn't depend on NLog and therfore doesn't know about NestedContext.

But I kept NestedContext around in NLog 5.0, because I was guessing it would allow remoting-calls between applications that depends on NLog 4 or 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarQube integrations seems to be broken
3 participants