Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogBeginScopeParser - Skip capture of nested state when List + Array + Dictionary #662

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 18, 2023

NLog v5.1.3 now ignores null when used as nested-state in ScopeContext.PushNestedStateProperties.

@snakefoot snakefoot changed the title NLogBeginScopeParser - Skip neste state capture for List + Array + Dictionary NLogBeginScopeParser - Skip capture of nested state when List + Array + Dictionary Mar 18, 2023
@snakefoot snakefoot force-pushed the master branch 2 times, most recently from c57a023 to a1f595d Compare March 18, 2023 09:53
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.23 ⚠️

Comparison is base (8ef4b2d) 80.90% compared to head (a1f595d) 80.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
- Coverage   80.90%   80.68%   -0.23%     
==========================================
  Files          19       19              
  Lines        1655     1662       +7     
  Branches      279      282       +3     
==========================================
+ Hits         1339     1341       +2     
- Misses        187      191       +4     
- Partials      129      130       +1     
Impacted Files Coverage Δ
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 67.42% <28.57%> (-1.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snakefoot snakefoot force-pushed the master branch 2 times, most recently from bd285bb to 53bc9f6 Compare March 22, 2023 22:47
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 22, 2023
@snakefoot snakefoot merged commit 3e59cae into NLog:master Mar 28, 2023
@snakefoot snakefoot added this to the 5.2.3 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants