Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callsite-filename renderer #2591

Merged
merged 2 commits into from
Mar 7, 2018
Merged

callsite-filename renderer #2591

merged 2 commits into from
Mar 7, 2018

Conversation

brunotag
Copy link
Contributor

Implementing #2583

@brunotag brunotag mentioned this pull request Feb 22, 2018
Closed
@codecov
Copy link

codecov bot commented Feb 22, 2018

Codecov Report

Merging #2591 into master will increase coverage by <1%.
The diff coverage is 91%.

@@           Coverage Diff           @@
##           master   #2591    +/-   ##
=======================================
+ Coverage      81%     81%   +<1%     
=======================================
  Files         325     326     +1     
  Lines       23918   23941    +23     
  Branches     3022    3025     +3     
=======================================
+ Hits        19378   19431    +53     
+ Misses       3709    3692    -17     
+ Partials      831     818    -13

@304NotModified 304NotModified self-assigned this Feb 22, 2018
@304NotModified
Copy link
Member

Thanks! Will try to review soon!

@304NotModified 304NotModified added this to the 4.5 rc7 milestone Mar 7, 2018
@304NotModified
Copy link
Member

Thanks! Could please add some docs to the wiki?

@304NotModified 304NotModified merged commit 0dfa761 into NLog:master Mar 7, 2018
@brunotag
Copy link
Contributor Author

brunotag commented Mar 8, 2018

sure will do

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Mar 8, 2018
@snakefoot snakefoot mentioned this pull request Mar 15, 2018
Closed
@snakefoot snakefoot modified the milestones: 4.5 rc7, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@304NotModified 304NotModified

Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature needs documentation on wiki
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@brunotag @304NotModified @snakefoot