Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutputDebugStringTarget - Support Xamarin iOS and Android #2792

Merged
merged 1 commit into from
Jul 17, 2018
Merged

OutputDebugStringTarget - Support Xamarin iOS and Android #2792

merged 1 commit into from
Jul 17, 2018

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jun 30, 2018 •
edited
Loading

Resolves #2799

@snakefoot snakefoot force-pushed the XamarinOutputDebugString branch 2 times, most recently from c81dafd to 8873a69 Compare June 30, 2018 19:23
@304NotModified
Copy link
Member

note: checked failed unit test

@snakefoot snakefoot mentioned this pull request Jul 13, 2018
Closed
@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8770641). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2792   +/-   ##
========================================
  Coverage          ?     81%           
========================================
  Files             ?     326           
  Lines             ?   24280           
  Branches          ?    3085           
========================================
  Hits              ?   19607           
  Misses            ?    3837           
  Partials          ?     836

@snakefoot
Copy link
Contributor Author

snakefoot commented Jul 13, 2018 •
edited
Loading

@304NotModified Force push resolved the failing test

@304NotModified
Copy link
Member

Thank you!

@304NotModified 304NotModified added this to the 4.5.7 milestone Jul 17, 2018
@304NotModified 304NotModified merged commit c515a3a into NLog:master Jul 17, 2018
@snakefoot
Copy link
Contributor Author

Updated wiki: https://github.com/NLog/NLog/wiki/OutputDebugString-target and https://github.com/NLog/NLog/wiki/platform-support

@304NotModified
Copy link
Member

thanks!

@snakefoot snakefoot deleted the XamarinOutputDebugString branch April 4, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.5.7
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified