MethodCallTarget - Support for Lamba method #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
MethodCallTargetDelegate
branch
from
40d5a4b
to
3c26867
Compare
Codecov Report
@@ Coverage Diff @@
## master #2809 +/- ##
=======================================
- Coverage 81% 81% -<1%
=======================================
Files 326 326
Lines 24280 24303 +23
Branches 3084 3088 +4
=======================================
+ Hits 19599 19609 +10
- Misses 3846 3857 +11
- Partials 835 837 +2 |
Doubting about this also. I'm reading this: https://stackoverflow.com/questions/2282476/actiont-vs-delegate-event |
304NotModified
changed the title
|
Updated documentation: https://github.com/NLog/NLog/wiki/MethodCall-target#configure-call-of-lambda-at-runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2780
Added constructor to allow fluent configuration
Not sure if it should be a declared delegate, or just leave it as an Action-delegate.