-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NLog.WindowsEventLog Package #2834
Conversation
By only defining NETSTANDARD2_0 and not NETSTANDARD, then it should be included. |
Codecov Report
@@ Coverage Diff @@
## master #2834 +/- ##
=======================================
+ Coverage 81% 81% +<1%
=======================================
Files 326 326
Lines 24413 24413
Branches 3106 3106
=======================================
+ Hits 19686 19695 +9
+ Misses 3884 3853 -31
- Partials 843 865 +22 |
Yes, also an option, but I think it's now more clear it also used in another package. |
I just mentioned how it was working now, and curious how your modification would change anything (besides making it more clear). Since the NLog.WindowsEventLog-project only defines NETSTANDARD2_0 (and not NETSTANDARD) |
But it is funny that https://www.nuget.org/packages/NLog.WindowsEventLog/4.5.6 is working (But not ver. 4.5.7). Maybe NETSTANDARD has become a default define in MsBuild ? |
@304NotModified The same problem also exist for "NLog.WindowsIdentity". https://www.nuget.org/packages/NLog.WindowsIdentity/4.5.6 is working (But ver. 4.5.7 does not) Please unlist the broken ver 4.5.7, and release a fixed ver 4.5.8 for that nuget-package also |
sounds plausible
thanks for checking, will do |
Fixes #2828