Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLog.WindowsEventLog Package #2834

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Conversation

304NotModified
Copy link
Member

Fixes #2828

@304NotModified 304NotModified added this to the 4.5.8 milestone Aug 2, 2018
@snakefoot
Copy link
Contributor

By only defining NETSTANDARD2_0 and not NETSTANDARD, then it should be included.

@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #2834 into master will increase coverage by <1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2834    +/-   ##
=======================================
+ Coverage      81%     81%   +<1%     
=======================================
  Files         326     326            
  Lines       24413   24413            
  Branches     3106    3106            
=======================================
+ Hits        19686   19695     +9     
+ Misses       3884    3853    -31     
- Partials      843     865    +22

@304NotModified
Copy link
Member Author

By only defining NETSTANDARD2_0 and not NETSTANDARD, then it should be included.

Yes, also an option, but I think it's now more clear it also used in another package.

@snakefoot
Copy link
Contributor

snakefoot commented Aug 3, 2018

I just mentioned how it was working now, and curious how your modification would change anything (besides making it more clear).

Since the NLog.WindowsEventLog-project only defines NETSTANDARD2_0 (and not NETSTANDARD)

@snakefoot
Copy link
Contributor

snakefoot commented Aug 3, 2018

But it is funny that https://www.nuget.org/packages/NLog.WindowsEventLog/4.5.6 is working (But not ver. 4.5.7). Maybe NETSTANDARD has become a default define in MsBuild ?

@snakefoot
Copy link
Contributor

snakefoot commented Aug 3, 2018

@304NotModified The same problem also exist for "NLog.WindowsIdentity". https://www.nuget.org/packages/NLog.WindowsIdentity/4.5.6 is working (But ver. 4.5.7 does not)

Please unlist the broken ver 4.5.7, and release a fixed ver 4.5.8 for that nuget-package also

@304NotModified
Copy link
Member Author

Maybe NETSTANDARD has become a default define in MsBuild ?

sounds plausible

@304NotModified The same problem also exist for "NLog.WindowsIdentity". https://www.nuget.org/packages/NLog.WindowsIdentity/4.5.6 is working (But ver. 4.5.7 does not)

Please unlist the broken ver 4.5.7, and release a fixed ver 4.5.8 for that nuget-package also

thanks for checking, will do

@304NotModified 304NotModified added the bug Bug report / Bug fix label Aug 3, 2018
@304NotModified 304NotModified changed the title Fix NLog.WindowsEventLogPackage Fix NLog.WindowsEventLog Package Aug 3, 2018
@304NotModified 304NotModified merged commit e1af746 into master Aug 3, 2018
@304NotModified 304NotModified deleted the fix-WindowsEventLogPackage branch August 3, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants