Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformDetector - Introduced detection of MacOSX, and removed WindowsCE #3155

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 4, 2019

Needed for #3124

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #3155 into dev will decrease coverage by <1%.
The diff coverage is 57%.

@@          Coverage Diff           @@
##             dev   #3155    +/-   ##
======================================
- Coverage     80%     80%   -<1%     
======================================
  Files        353     353            
  Lines      27798   27794     -4     
  Branches    3686    3685     -1     
======================================
- Hits       22170   22152    -18     
- Misses      4575    4589    +14     
  Partials    1053    1053

@snakefoot
Copy link
Contributor Author

@304NotModified Ready for review

@304NotModified 304NotModified merged commit 1a371dd into NLog:dev Mar 5, 2019
@304NotModified
Copy link
Member

Thanks :) !

@304NotModified 304NotModified added this to the 4.6 milestone Mar 5, 2019
@snakefoot snakefoot deleted the PlatformDetectorMacOSX branch April 4, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants