NetworkTarget - HttpNetworkSender no longer sends out-of-order #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
added
enhancement
304NotModified
approved these changes
Aug 13, 2019
snakefoot
force-pushed
the
NetWorkTargetHttpQueueSender
branch
3 times, most recently
from
c8e50c0
to
dff0b1f
Compare
|
Added unit test that shows that it will not discard pending http-requests because one http-request has failed (NetworkTarget still discards active HttpNetworkSender on error, and creates new) |
|
Cool! |
…ill flush correctly
snakefoot
force-pushed
the
NetWorkTargetHttpQueueSender
branch
from
dff0b1f
to
9545cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And will flush correctly (delays flush completed until request completed). Resolves #3544 (See also #3542)
Will probably also improve the allocation pattern, as TCP-NetworkSender will delay allocation of
SocketAsyncEventArgs-instances until ready to send. This will reduce the chance that they enter GC1.Ofcourse the allocation pattern could become even better by reusing the
SocketAsyncEventArgs-instance for the next TCP-NetworkSender-operation. And one could improve it even more by allocating byte-arrays in predefined sizes (512 bytes. 1024 bytes. 2048 bytes, etc.). And then check if room is available in the previous unsent allocated byte-array before creating new.