Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigurationItemFactory - Include ConditionMethods in registration #5268

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jun 27, 2023

Resolves #5260, Folloup to #5191

Replaced expression-tree-compilation with direct method calls. Discovered that expression-tree-compilation doesn't work well with PublishAOT (Because dynamic compiler is not available). See also Improve performance with Expression Trees

@snakefoot snakefoot added the enhancement Improvement on existing feature label Jun 27, 2023
@snakefoot snakefoot added this to the 5.2.1 milestone Jun 27, 2023
@snakefoot snakefoot force-pushed the register-methods branch 6 times, most recently from ed96707 to b9ac50d Compare July 1, 2023 13:46
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

88.1% 88.1% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot enabled auto-merge (squash) July 1, 2023 14:32
@snakefoot snakefoot merged commit a9dd3fb into NLog:dev Jul 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConditionMethodExpression - Without reflection by default
1 participant