-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check matching #199
Check matching #199
Conversation
@felixhekhorn instead of manually squaring all of those instances, wouldn't just be easier to add a |
This had the least impact on the |
The base branch was changed.
I liked more to have the type, but maybe we should solve later on in a more involved way: we can consider to have inheritance from a couple of markers like I'd really like to clean up consistently the usage of linear and squared scales. But we will do in a separate PR. |
these are (mostly) some plotting scripts to check matching away from threshold is working in eko - in especially redo fig. 6 from the eko paper for PDFs.
While doing this I did indeed find a bug: d671cc0 introduced with #172 in
develop
(not in v0.10 which I was using for the "quick" plot @alecandido - I have to redo my current version of the plots). I still have to fix all the tests.