Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check matching #199

Merged
merged 9 commits into from
Jan 31, 2023
Merged

Check matching #199

merged 9 commits into from
Jan 31, 2023

Conversation

felixhekhorn
Copy link
Contributor

@felixhekhorn felixhekhorn commented Jan 19, 2023

these are (mostly) some plotting scripts to check matching away from threshold is working in eko - in especially redo fig. 6 from the eko paper for PDFs.

While doing this I did indeed find a bug: d671cc0 introduced with #172 in develop (not in v0.10 which I was using for the "quick" plot @alecandido - I have to redo my current version of the plots). I still have to fix all the tests.

@felixhekhorn felixhekhorn added the bug Something isn't working label Jan 19, 2023
@alecandido
Copy link
Member

alecandido commented Jan 23, 2023

@felixhekhorn instead of manually squaring all of those instances, wouldn't just be easier to add a squared properties to MatchingScales?

@felixhekhorn
Copy link
Contributor Author

@felixhekhorn instead of manually squaring all of those instances, wouldn't just be easier to add a squared properties to MatchingScales?

This had the least impact on the eko module (since the linear already got computed). We can reconsider this in #181. I would try to close this asap to not block an eko release.

giacomomagni
giacomomagni previously approved these changes Jan 25, 2023
@alecandido alecandido changed the base branch from develop to master January 27, 2023 14:08
@alecandido alecandido dismissed giacomomagni’s stale review January 27, 2023 14:08

The base branch was changed.

src/eko/msbar_masses.py Outdated Show resolved Hide resolved
@alecandido
Copy link
Member

I liked more to have the type, but maybe we should solve later on in a more involved way: we can consider to have inheritance from a couple of markers like EnergyScale and SquaredEnergyScale (unless we can parametrize type with numbers, then we can use EnergyScale[1] and EnergyScale[2]) in order to make our code safer and more explicit.

I'd really like to clean up consistently the usage of linear and squared scales. But we will do in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants