Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of libarchive #1130

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Bump version of libarchive #1130

merged 3 commits into from
Mar 10, 2021

Conversation

Zaharid
Copy link
Contributor

@Zaharid Zaharid commented Mar 5, 2021

If I try to set up a clean environment on linux I get essentially this
error:

conda/conda#8838

when trying to import NNPDF, which as said on the issue gets solved if
one installs libiconv manually. Indeed checking libarchive with ldd
I see that it is asking for libiconv and not finding it.

It seems there is some amount of dancing around of dancing around in the
conda forge channel with it being added

conda-forge/libarchive-feedstock#36

and then removed

conda-forge/libarchive-feedstock#59

and seems that that somehow can result in an incompatible environment.

Pull to the latest version (and be stricter with
pinning in hopes that resolves the problem.

If I try to set up a clean environment on linux I get essentially this
error:

conda/conda#8838

when trying to import NNPDF, which as said on the issue gets solved if
one installs libiconv manually. Indeed checking libarchive with ldd
I see that it is asking for libiconv and not finding it.

It seems there is some amount of dancing around of dancing around in the
conda forge channel with it being added

conda-forge/libarchive-feedstock#36

and then removed

conda-forge/libarchive-feedstock#59

and seems that that somehow can result in an incompatible environment.

Pull to the latest version (and be stricter with
pinning in hopes that resolves the problem.
@Zaharid
Copy link
Contributor Author

Zaharid commented Mar 6, 2021

Ok so this manages to fail at compile time

/root/miniconda3/conda-bld/nnpdf_1614969218489/_build_env/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: /root/miniconda3/conda-bld/nnpdf_1614969218489/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/libarchive.so: undefined reference to `libiconv'
collect2: error: ld returned 1 exit status
make[2]: *** [libnnpdf/FKmerge2] Error 1

@siranipour
Copy link
Contributor

How come the travis builds weren't failing for other PRs? Or were they?

@Zaharid
Copy link
Contributor Author

Zaharid commented Mar 8, 2021

I think it is pulling a new version later at runtime, as we didn't constrain it very much.

@Zaharid Zaharid requested a review from scarlehoff March 9, 2021 16:20
@Zaharid
Copy link
Contributor Author

Zaharid commented Mar 9, 2021

Spent a while trying to reliably reproduce this issue so i can report but I have no idea of what is going on. If I just try to install libarchive I get a version that seems to work fine. Anyhow it should be good enough for what we are trying to do.

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the error is or should be but if I do a "vanilla" conda install nnpdf I get this version of libarchive so I guess it is ok to pin it. Not entirely sure how to test this issue because I don't think I've seen it.

@Zaharid Zaharid merged commit 65208fc into master Mar 10, 2021
@Zaharid Zaharid deleted the bumplibarchive branch March 10, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants